-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move hiding only to the SectionList #33833
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: NativeCleanShot.2024-01-03.at.15.57.31.mp4Android: mWeb ChromeCleanShot.2024-01-03.at.16.05.06.mp4iOS: NativeCleanShot.2024-01-03.at.13.49.23.mp4iOS: mWeb SafariCleanShot.2024-01-03.at.16.01.20.mp4MacOS: Chrome / SafariCleanShot.2024-01-03.at.13.26.03.mp4MacOS: DesktopCleanShot.2024-01-03.at.13.36.41.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and PR tests well. Thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/deetergp in version: 1.4.23-0 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.23-4 🚀
|
@@ -479,7 +478,7 @@ function BaseSelectionList({ | |||
viewabilityConfig={{viewAreaCoveragePercentThreshold: 95}} | |||
testID="selection-list" | |||
onLayout={scrollToFocusedIndexOnFirstRender} | |||
style={!maxToRenderPerBatch && styles.opacity0} | |||
style={(!maxToRenderPerBatch || isInitialSectionListRender) && styles.opacity0} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Details
Fixed Issues
$ #29780
PROPOSAL: #29780 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
33833_android.mp4
Android: mWeb Chrome
iOS: Native
33833_ios.mp4
iOS: mWeb Safari
33833_web_ios.mp4
MacOS: Chrome / Safari
33833_web.mp4
MacOS: Desktop
33833_desktop.mp4